Merging restic-server #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Commit ID in fd0/restic-server at time of merge is 07fae00
- Removed external dependencies for test - Prevent building restic-server w/ Go 1.3 Go versions 1.0, 1.1., and 1.2 are going to fail as well, but they are "excluded" by README.md already.
Before, the restic-server read the whole blob (up to 8MB) into memory prior to writing it to disk. Concurrent writes consumed a lot of memory. This change writes the blob to a tmp file directly and renames it afterwards in case there where no errors.
|
Why merge it? IMO it's better kept as a separate project to keep restic's code base leaner. Especially since it can be run fully free of dependencies against restic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to merge bchapuis/restic-server as a subtree (src/restic/cmd/restic-server). I also took the liberty of gb vendoring all requirements for the tests.
Changes beside the merge are: