Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to Go Match syntax directly in 040_backup.rst #4670

Merged
merged 1 commit into from Feb 2, 2024

Conversation

joram-berger
Copy link
Contributor

The docs linked to filepath.Glob (which is used) but the syntax is described in the documentation of filepath.Match. So it makes sense to link that directly.

What does this PR change? What problem does it solve?

It improves the documentation by directly linking to the glob/match syntax description.

Was the change previously discussed in an issue or on the forum?

Discussed in https://forum.restic.net/t/about-files-from-file-format/7211/7

Checklist

  • I have read the contribution guidelines.
  • I have enabled maintainer edits.
  • I have added tests for all code changes.
  • I have added documentation for relevant changes (in the manual).
  • There's a new file in changelog/unreleased/ that describes the changes for our users (see template).
  • I have run gofmt on the code in all commits.
  • All commit messages are formatted in the same style as the other commits in the repo.
  • I'm done! This pull request is ready for review.

The docs linked to filepath.Glob (which is used) but the syntax is described in the documentation of filepath.Match. So it makes sense to link that directly.
Copy link
Contributor

@rawtaz rawtaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM, thanks!

@MichaelEischer MichaelEischer added this pull request to the merge queue Feb 2, 2024
Merged via the queue into restic:master with commit cbf9cd4 Feb 2, 2024
12 checks passed
@joram-berger joram-berger deleted the patch-1 branch February 2, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants