Use tempfiles for not-yet-uploaded pack files #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| const minPackSize = 4 * 1024 * 1024 | ||
| const maxPackSize = 16 * 1024 * 1024 | ||
| const maxPackers = 200 | ||
|
|
||
| // NewPackerManager returns an new packer manager which writes temporary files | ||
| // to a temporary directory | ||
| func NewPackerManager(be Saver, key *crypto.Key) *packerManager { |
There was a problem hiding this comment.
exported func NewPackerManager returns unexported type *repository.packerManager, which can be annoying to use
This can be removed once we require Go 1.6.
This needs to be done since for Go < 1.6 rand.Rand does not implement io.Reader.
fd0
added a commit
that referenced
this pull request
Mar 6, 2016
Use tempfiles for not-yet-uploaded pack files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces memory usage, as pack files that haven't been uploaded yet are not held in memory but written to temp files.