-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic host,tag columns widths in snapshots command #854
Dynamic host,tag columns widths in snapshots command #854
Conversation
Codecov Report
@@ Coverage Diff @@
## master #854 +/- ##
==========================================
+ Coverage 53.2% 53.57% +0.36%
==========================================
Files 91 91
Lines 7511 7517 +6
==========================================
+ Hits 3996 4027 +31
+ Misses 2918 2888 -30
- Partials 597 602 +5
Continue to review full report at Codecov.
|
Hm, this PR contains two commits from #853, wait for that PR to be merged into master and then rebase it? Maybe git is also smart enough to recognize this, we can try... A small thing for further commits (you don't need to rework the existing ones): May I ask you to adhere to the general style we use for commits (short subject line, no dot at the end)? It is documented here: https://github.com/restic/restic/blob/master/CONTRIBUTING.md#git-commits |
Ack on both your comments. I hope I remember the no-dot, they ingrain proper sentences at my work :P |
Interesting, I suppose that's a cultural thing. Are you also using git at work? I can also add an integration test which check the end of the subject line 😛 |
…d_snapshots Dynamic host,tag columns widths in snapshots command
Ok, it let me merge this just fine. |
Awesome! I shall try to not stack PRs on top of each other in the future. |
Ok, this irritated me now long enough. Columns widths are now dynamic, with reasonable minimums.
Example output. Note how my FQDN hostname are way longer than 10 chars.
(excuse the ascii art, the program created it :P)