Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize List() pipeline #867

Merged
merged 1 commit into from
Mar 8, 2017
Merged

Optimize List() pipeline #867

merged 1 commit into from
Mar 8, 2017

Conversation

middelink
Copy link
Member

... I wanted to use contexts here too, but that requires too much plumbing right now.

@codecov-io
Copy link

Codecov Report

Merging #867 into master will decrease coverage by -0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #867      +/-   ##
==========================================
- Coverage   53.54%   53.44%   -0.11%     
==========================================
  Files          92       92              
  Lines        7636     7610      -26     
==========================================
- Hits         4089     4067      -22     
+ Misses       2931     2928       -3     
+ Partials      616      615       -1
Impacted Files Coverage Δ
src/restic/mock/repository.go 57.05% <0%> (-2.42%)
src/restic/archiver/archiver.go 64.96% <0%> (+0.22%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5a55a8...7c989ca. Read the comment docs.

Copy link
Member

@fd0 fd0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, that code was probably a bit too complicated. Cancelling the sending is handled by backend.List(), so it's fine.

@fd0 fd0 merged commit 7c989ca into restic:master Mar 8, 2017
fd0 added a commit that referenced this pull request Mar 8, 2017
@middelink middelink deleted the optimize branch March 8, 2017 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants