fix(HttpClient): attach readable event after data to keep response st…

…ream flow (#175)

lib/HttpClient.js

@@ -209,10 +209,6 @@ function rawRequest(opts, cb) {
 
         req.removeAllListeners('socket');
 
-        res.once('readable', function onReadable () {
-            eventTimes.firstByteAt = process.hrtime();
-        });
-
         // End event is not emitted when stream is not consumed fully
         // in our case we consume it see: res.on('data')
         res.once('end', function onEnd () {
@@ -223,6 +219,15 @@ function rawRequest(opts, cb) {
         });
 
         emitResult((err || null), req, res);
+
+        // This has to be after res.on('data') in Node >= v10:
+        // Adding a 'readable' listener stay in non-flowing mode even after
+        // a 'data' event listener is added to the same stream:
+        // https://github.com/nodejs/node/commit/
+        // cf5f9867ff3e700dfd72519e7bdeb701e254317f
+        res.once('readable', function onReadable () {
+            eventTimes.firstByteAt = process.hrtime();
+        });
     });
     req.log = log;
 

test/StringClient.test.js

@@ -39,6 +39,22 @@ describe('StringClient', function () {
         SERVER.close(done);
     });
 
+    it('should make a request',
+    function (done) {
+        SERVER.get('/ping', function (req, res, next) {
+            res.send('pong');
+            return next();
+        });
+
+        CLIENT.get({
+            path: '/ping'
+        }, function (err, req, res, data) {
+            assert.ifError(err);
+            assert.equal(data, 'pong');
+            return done();
+        });
+    });
+
     it('should support decoding gzipped utf8 multibyte responses',
     function (done) {
         var payload = fs.readFileSync(path.join(