upgrade: upgrade dev deps and move from jscs to eslint #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
DonutEspresso
force-pushed
the
rev-dev-deps
branch
from
9f7f088
to
543239f
Compare
DonutEspresso
force-pushed
the
rev-dev-deps
branch
from
543239f
to
541f711
Compare
|
Closing, I think we should move to using something like prettier. Maybe we can reuse the same configuration and settings from restify/node-restify#1537. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In upgrading restify to 6.x as a test dependency, this uncovered restify/node-restify#1607.
Those two tests are currently skipped, will circle back and fix/remove after regression/tests have been added back to main restify repo.