Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: hot reload functionallity #14

Merged
merged 6 commits into from May 23, 2018
Merged

new: hot reload functionallity #14

merged 6 commits into from May 23, 2018

Conversation

DonutEspresso
Copy link
Member

Continuation of #13.

@DonutEspresso
Copy link
Member Author

DonutEspresso commented May 22, 2018

@yunong this might be a good place to help out with - this would be a huge win for devprod immediately. Open questions:

  • should the hot reload configuration be an enroute schema configuration or a runtime option when you call install? (I prefer latter)
  • are the typed errors a major breaking change? (I prefer yes)
  • what's a good way to add a test for this? (add a test that changes the response payload and verify it that way?)

Also need to update README

@yunong
Copy link
Member

yunong commented May 23, 2018

@DonutEspresso Landed tests and docs.

@DonutEspresso
Copy link
Member Author

Wah wah, fs-extra breaks on node4 due to some ES6 syntax. It looks like a dev time dependency only, are there other alternatives? Or we can make this a breaking change for enroute by dropping node4 support?

@yunong
Copy link
Member

yunong commented May 23, 2018

Already dropped v4 support ;)

Copy link
Member Author

@DonutEspresso DonutEspresso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. is this a new major version then?

@yunong
Copy link
Member

yunong commented May 23, 2018

Looks like it

@yunong yunong merged commit 7a6654e into master May 23, 2018
@wesleytodd wesleytodd deleted the hot-reload branch November 3, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants