Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serveStatic does not append " does not exist" to err.message on 404 #455

Closed
jvanalst opened this issue Oct 1, 2013 · 1 comment
Closed
Labels

Comments

@jvanalst
Copy link

jvanalst commented Oct 1, 2013

All other automatic restify.ResourceNotFoundErrors append

" does not exist"

to the end of the err.message.

E.g. on an undefined route:

{
  code: "ResourceNotFound",
  message: "/Makefile does not exist"
}

E.g. on a statically served path:

{
  code: "ResourceNotFound",
  message: "/assets/Makefile"
}

It's a minor inconsistency in the 404 errors messages. Simply 2 line change as well...
Line #36 and line #39 in lib/plugins/static.js

@thisandagain
Copy link
Contributor

👍 Great catch. Mind sending along a pull request?

@gergelyke gergelyke added the bug label Feb 10, 2014
gergelyke pushed a commit that referenced this issue Feb 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants