added optional limit, rate and remaining headers when using throttle #1425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retrohacker
requested changes
Aug 16, 2017
There was a problem hiding this comment.
Once we add the assert statement, this looks good to me! 👍 great work on this @eps1lon !
| var tooManyRequests = !bucket.consume(1); | ||
|
|
||
| // set throttle headers after consume which changes the remaining tokens | ||
| if (options.setHeaders) { |
There was a problem hiding this comment.
At the top of this function, we should assert options.setHeaders is an optional boolean.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As request in #1344 this exposes headers that specify how the api is throttled. This will not happen unless explicitly set in
setHeaders.Added headers are:
X-RateLimit-Remainingfor remaining tokensX-RateLimit-Limitfor burstX-RateLimit-Ratefor the refresh reateI did some quick research and i only found that Twitter uses
x-rate-limit-*instead of camelCase.Most changes were made in the test since i had to setup a new server for that test. As far es I can tell there is no way to change plugins options after they were added.