Handle non-trailing slashes correctly #1512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 28, 2017 08:58
BREAKING CHANGE: use server.pre(restify.plugins.pre.dedupeSlashes()) to deal with double slashes
hekike
added a commit
that referenced
this pull request
Jan 30, 2018
* router - remove do not merge double slashes by default * use server.pre(restify.plugins.pre.dedupeSlashes()) to deal with double slashes * refactor test to cover multiple slashes cases
hekike
added a commit
that referenced
this pull request
Feb 23, 2018
* router - remove do not merge double slashes by default * use server.pre(restify.plugins.pre.dedupeSlashes()) to deal with double slashes * refactor test to cover multiple slashes cases
hekike
added a commit
that referenced
this pull request
Mar 13, 2018
* router - remove do not merge double slashes by default * use server.pre(restify.plugins.pre.dedupeSlashes()) to deal with double slashes * refactor test to cover multiple slashes cases
hekike
added a commit
that referenced
this pull request
Mar 20, 2018
* router - remove do not merge double slashes by default * use server.pre(restify.plugins.pre.dedupeSlashes()) to deal with double slashes * refactor test to cover multiple slashes cases
hekike
added a commit
to sfaizanh/node-restify
that referenced
this pull request
Mar 27, 2018
* router - remove do not merge double slashes by default * use server.pre(restify.plugins.pre.dedupeSlashes()) to deal with double slashes * refactor test to cover multiple slashes cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Closes:
#1464
#1478
Non-trailing slash leads to incorrect routing match (and parameter parsing).
Changes
Fix router regexp matching with non-trailing slash(es)