chore: use github ci #1836
Merged
chore: use github ci #1836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improves integration with github actions
ghermeto
force-pushed
the
chore/github-ci
branch
from
0711423
to
8b81ceb
Compare
mmarchini
approved these changes
Jun 28, 2020
| fail-fast: false | ||
| matrix: | ||
| os: | ||
| - ubuntu-latest |
There was a problem hiding this comment.
Should we also test on OS X?
There was a problem hiding this comment.
tests are super-flaky on macos-latest. The tests for request closed are failing randomly... I will leave macos out until we have time to review them.
mmarchini
reviewed
Jun 28, 2020
Co-authored-by: Matheus Marchini <mmarchini@netflix.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improves integration with Github Actions.
Maintainance PR. Will remove Travis on subsequent PR if Github CI meets the expectation.