Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Very small change that will allow contentWriters to make use of the res o #33

Merged
merged 1 commit into from Jul 18, 2011
Merged

Conversation

benhowes
Copy link
Contributor

Hey,

Thanks for an awesome module that has saved me from all the mess I was having with getting connect set up as a rest API. Really is awesome :)

My application unfortunately requires cross domain calls and hence I need to use JSONP. As I think is the normal way, the callback name that the response should be wrapped in will be added to the query string by the client. This means that I need access to more data than is available (unless I have a magic key in the object passed in).

This very small change that will allow contentWriters to make use of the res object as this if extra parameters are required. This change unifies the style with the contentHandler also.

Thanks,
Ben

…es object as this if extra parameters are required. This change unifies the style with the contentHandler also
@benhowes
Copy link
Contributor Author

whoops - I have just seen that I missed off a ';', sorry about that. That's what you get for writing coffeescript all the time!

@mcavage
Copy link
Contributor

mcavage commented Jul 18, 2011

Hi Ben,

Yeah, that's a pretty sane change to me (of course, assuming I add in the ';' ;-) ). I'll take it.

mcavage added a commit that referenced this pull request Jul 18, 2011
Very small change that will allow contentWriters to make use of the res o
@mcavage mcavage merged commit bbfff47 into restify:master Jul 18, 2011
@benhowes
Copy link
Contributor Author

Thanks mcavage!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants