Route matching should only prefer later routes if version is greater #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous logic would prefer a later route if the max version satisfying the request was greater than ANY version of the previously matched route. This fixes the logic to only compare the max version satisfying the request of previous candidates.
| @@ -363,17 +363,16 @@ Router.prototype.find = function find(req, res, callback) { | |||
| } | |||
|
|
|||
| if (versioned) { | |||
| var maxV; | |||
There was a problem hiding this comment.
what is the point of this variable? in line375 a value is assigned to it, but for what? the code never uses it afterwards.
There was a problem hiding this comment.
sorry :/ the git diff confused me :)
|
it looks fine, thanks for the contrib! we are releasing a version today/tomorrow, so it will be released next time! |
gergelyke
added a commit
that referenced
this pull request
Apr 17, 2014
Route matching should only prefer later routes if version is greater
gergelyke
pushed a commit
that referenced
this pull request
Apr 18, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous logic would prefer a later route if the max version
satisfying the request was greater than ANY version of the previously
matched route. This fixes the logic to only compare the max version
satisfying the request of previous candidates.