feat: manualOffsetCommit is optional

restorecommerce · Apr 9, 2024 · 0f39d96 · 0f39d96
1 parent 1b524c0
commit 0f39d96
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/packages/kafka-client/src/events/index.ts b/packages/kafka-client/src/events/index.ts
@@ -98,7 +98,7 @@ export class Events {
    * @param  {string} name Topic name
    * @return {Topic}      Topic
    */
-  topic(name: string, manualOffsetCommit: boolean): Promise<Topic> {
+  topic(name: string, manualOffsetCommit?: boolean): Promise<Topic> {
     if (_.isNil(name)) {
       throw new Error('missing argument name');
     }
@@ -107,6 +107,6 @@ export class Events {
     }
     // topic() api called inside Local / Kafka class - which then
     // invokes the actual topic constructor
-    return this.provider.topic(name, this.config, manualOffsetCommit);
+    return this.provider.topic(name, this.config, manualOffsetCommit || false);
   }
 }
diff --git a/packages/kafka-client/src/events/provider/kafka/index.ts b/packages/kafka-client/src/events/provider/kafka/index.ts
@@ -409,8 +409,6 @@ export class Topic {
           this.provider.logger.info('Consumer connection reset successfully');
         }
       });
-    } else {
-      this.commitOffset();
     }
   }