chore(node20): upgrade to node 20

.github/workflows/build.yaml

@@ -12,7 +12,7 @@ jobs:
       - name: Setup NodeJS
         uses: actions/setup-node@v1
         with:
-          node-version: '18.2.0'
+          node-version: '20.8.0'
 
       - name: Install Dependencies
         run: npm ci
@@ -30,7 +30,7 @@ jobs:
       - name: Setup NodeJS
         uses: actions/setup-node@v1
         with:
-          node-version: '18.2.0'
+          node-version: '20.8.0'
 
       - name: Setup System
         uses: restorecommerce/setup-system-action@v1

package.json

@@ -68,7 +68,7 @@
     "tsctests": "tsc -d -p tsconfig.test.json"
   },
   "engines": {
-    "node": ">= 16.0.0"
+    "node": ">= 18.0.0"
   },
   "config": {
     "commitizen": {

src/experimental/access_control_decorators.ts

@@ -48,20 +48,20 @@ export function access_controlled_service<T extends { new (...args: any): {} }>(
 }
 
 export function access_controlled_function(kwargs: {
-  action: AuthZAction,
-  operation: Operation,
-  context?: ACSClientContext | ACSClientContextFactory,
-  resource?: Resource[] | ResourceFactory,
-  database?: 'arangoDB' | 'postgres',
-  useCache?: true
+  action: AuthZAction;
+  operation: Operation;
+  context?: ACSClientContext | ACSClientContextFactory;
+  resource?: Resource[] | ResourceFactory;
+  database?: 'arangoDB' | 'postgres';
+  useCache?: true;
 }) {
   return function (
     target: any,
     propertyName: string,
     descriptor: TypedPropertyDescriptor<any>,
   ) {
     const method = descriptor.value!;
-    
+
     descriptor.value = async function () {
       try {
         if (!this.user_service) {
@@ -75,7 +75,7 @@ export function access_controlled_function(kwargs: {
         const resource = typeof(kwargs.resource) === 'function'
           ? await kwargs.resource(this, ...arguments)
           : kwargs.resource;
-        
+
         const subject = context?.subject;
         if (subject?.token) {
           const user = await this.user_service.findByToken({ token: subject.token });
@@ -93,7 +93,7 @@ export function access_controlled_function(kwargs: {
           kwargs.database ?? 'arangoDB',
           kwargs.useCache ?? false
         );
-        console.log(response?.decision);
+
         if (response?.decision !== Response_Decision.PERMIT) {
           return response;
         }
@@ -105,11 +105,11 @@ export function access_controlled_function(kwargs: {
             code: err.code ?? 500,
             message: err.details ?? err.message ?? err,
           }
-        }
+        };
       }
       return await method.apply(this, arguments);
     };
-  }
+  };
 }
 
 export const DefaultACSClientContextFactory: ACSClientContextFactory = (

src/service.ts

@@ -27,7 +27,7 @@ import {
   OrderIdList,
   OrderListResponse,
   OrderServiceImplementation,
-  OrderInvoiceRequestList,
+  OrderingInvoiceRequestList,
   FulfillmentInvoiceMode,
 } from '@restorecommerce/rc-grpc-clients/dist/generated-server/io/restorecommerce/order';
 import {
@@ -67,6 +67,7 @@ import {
   FulfillmentResponse,
   FulfillmentList,
   Packaging,
+  Parcel,
 } from '@restorecommerce/rc-grpc-clients/dist/generated-server/io/restorecommerce/fulfillment';
 import {
   FulfillmentProductServiceDefinition,
@@ -155,7 +156,7 @@ export class OrderingService
       subject: request.subject,
       resources,
     };
-  } 
+  }
 
   private readonly status_codes: { [key: string]: Status } = {
     OK: {
@@ -1695,7 +1696,7 @@ export class OrderingService
   }
 
   private async toInvoiceResponsePrototypes(
-    request: OrderInvoiceRequestList,
+    request: OrderingInvoiceRequestList,
     context?: any,
   ): Promise<InvoiceResponse[]> {
     const order_map = await this.getOrderMap(
@@ -1799,7 +1800,7 @@ export class OrderingService
                   })
                 );
 
-                const fulfillment_items = Object.values((
+                const fulfillment_items: Parcel[] = Object.values((
                   section.fulfillment_mode === FulfillmentInvoiceMode.INCLUDE && (
                     section.selected_fulfillments?.flatMap(
                       selection => fulfillment_map[section.order_id].find(
@@ -1892,7 +1893,7 @@ export class OrderingService
     useCache: true,
   })
   public async createInvoice(
-    request: OrderInvoiceRequestList,
+    request: OrderingInvoiceRequestList,
     context?: any,
   ): Promise<InvoiceListResponse> {
     try {
@@ -1946,7 +1947,7 @@ export class OrderingService
     useCache: true,
   })
   public async triggerInvoice(
-    request: OrderInvoiceRequestList,
+    request: OrderingInvoiceRequestList,
     context?: any,
   ): Promise<StatusListResponse> {
     return null;