Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Equals and GetHashCode methods to RestRequest #1554

Closed
AndyLPK247 opened this issue Jan 31, 2021 · 2 comments
Closed

Add Equals and GetHashCode methods to RestRequest #1554

AndyLPK247 opened this issue Jan 31, 2021 · 2 comments
Labels

Comments

@AndyLPK247
Copy link

This is a new feature request:
Please add Equals and GetHashCode methods to RestRequest.

RestRequest objects are essentially specifications for requests. They include almost all the data needed to make a REST request: resource, method, parameters, body, etc. It would be very helpful to add Equals and GetHashCode methods to RestRequest so that different request objects could be compared. For example, if two request objects hold identical request specs, then they should be equal and yield the same hash code value. If they are different, such as one being GET while the other being POST, then they should not be equal, and their hash codes should be different.

(I'm working on a project where I need to implement hash codes for classes that hold RestRequest/IRestRequest instance variables. I could implement my own scheme in my project, but I thought it could potentially be useful for others if RestRequest itself had these methods.)

Please let me know if this feature request is something the project would like to pursue. I'd be happy to try to help. Thanks!

@stale
Copy link

stale bot commented Jun 2, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jun 2, 2021
@repo-ranger
Copy link

repo-ranger bot commented Jun 2, 2021

⚠️ This issue has been marked wontfix and will be closed in 3 days

@repo-ranger repo-ranger bot closed this as completed Jun 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant