Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mark ErrorException as nullable to match interface #1548

Merged
merged 1 commit into from Dec 21, 2020
Merged

mark ErrorException as nullable to match interface #1548

merged 1 commit into from Dec 21, 2020

Conversation

mhornbacher
Copy link
Contributor

@mhornbacher mhornbacher commented Dec 21, 2020

Description

This resolves issue #1547 and related issues

Purpose

This pull request is a:

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added tests that prove my fix is effective or that my feature works (no additional tests needed)
  • I have added necessary documentation (matches existing documentation)

@mhornbacher
Copy link
Contributor Author

mhornbacher commented Dec 21, 2020

Hu, it seems that the test suite failed to build the project, dotnet test runs fine locally...

@alexeyzimarev alexeyzimarev merged commit 0ed7b0a into restsharp:dev Dec 21, 2020
6 of 7 checks passed
@alexeyzimarev
Copy link
Member

alexeyzimarev commented Dec 21, 2020

@mhornbacher thanks 👍

Some tests are inconclusive due to the build agent specifics, I guess.

@mhornbacher
Copy link
Contributor Author

mhornbacher commented Dec 21, 2020

Hu, not so happy merging to dev/main a commit where the test suite does not run. I wonder if it has to do with using C# 8 nullable on non-interface code.

@mhornbacher
Copy link
Contributor Author

mhornbacher commented Dec 21, 2020

Hu, it would seem that other PR's are having the exact same issue: https://github.com/restsharp/RestSharp/pull/1546/checks?check_run_id=1588074709

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants