Commits on Mar 18, 2022

1. If you have a timeout on the client AND a timeout on the request, the… …

   … resulting actual timeout is going to be the shorter of the two. By default HttpClient has a timeout of 100 seconds built in, so that means if someone is expecting to be able to send a request and have it wait longer than 100 seconds, it won't work unless the client is also changed.
   
   So I propose we change the property in RestClientOptions which is then applied to HttpClient to be called MaxTimeout so it is a lot more clear what the connection is? You cannot have a longer timeout for any request unless you change this value.
   
   It might also make sense to set this to a default value of something (maybe 100 seconds to make it clear) rather than leaving it null, so the user of the library will be more aware of how the client timeout and request timeout interact with each other?
   
   The other option would be to always set the timeout in the client to infinite, and then always use a request timeout that is the Max() of either the client timeout or the request one if the request one was provided?

   

   kendallb committed Mar 18, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for 5bbdcf3
   • Browse repository at this point

   Copy the full SHA

   5bbdcf3 View commit details

   Browse the repository at this point in the history