Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add cancellation support overload #1870

Merged
merged 1 commit into from
Jul 7, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/RestSharp/Sync/RestClient.Sync.cs
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,17 @@ public partial class RestClient {
/// Executes the request synchronously, authenticating if needed
/// </summary>
/// <param name="request">Request to be executed</param>
public RestResponse Execute(RestRequest request) => AsyncHelpers.RunSync(() => ExecuteAsync(request));
/// <param name="cancellationToken">The cancellation token</param>
public RestResponse Execute(RestRequest request, CancellationToken cancellationToken = default)
=> AsyncHelpers.RunSync(() => ExecuteAsync(request, cancellationToken));

/// <summary>
/// A specialized method to download files as streams.
/// </summary>
/// <param name="request">Pre-configured request instance.</param>
/// <param name="cancellationToken">The cancellation token</param>
/// <returns>The downloaded stream.</returns>
[PublicAPI]
public Stream? DownloadStream(RestRequest request) => AsyncHelpers.RunSync(() => DownloadStreamAsync(request));
public Stream? DownloadStream(RestRequest request, CancellationToken cancellationToken = default)
=> AsyncHelpers.RunSync(() => DownloadStreamAsync(request, cancellationToken));
}