Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token issues #1955

Merged
merged 1 commit into from Nov 7, 2022
Merged

Token issues #1955

merged 1 commit into from Nov 7, 2022

Conversation

edobbsskylark
Copy link
Contributor

While following this page and using it a lot while learning APIs, I had an issue where every request I was making to my client, it would reach out to get a new token. I assume this is not intended, and this was my fix for it. The local variable 'token' in the GetAuthenticationParameter function doesn't live outside of this and there for the obtained bearer token is never saved to the client object. I just forced the gettoken function to save to the Token variable that is in AuthenticatorBase.

Please let me know if I am missing something as I would love to learn!

I do figure that this does not take into account "what if the bearer token expires?" And to be honest I have no clue how this is handled! I plan on doing some checks if the request comes back with unauthorized, to get a new token, but if you have ideas or know of better ways to handle bearer tokens expiring please let me know! I am new to working with APIs.

Description

Purpose

This pull request is a:

  • [x ] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

While following this page and using it a lot while learning APIs, I had an issue where every request I was making to my client, it would reach out to get a new token.  I assume this is not intended, and this was my fix for it.  The local variable 'token' in the GetAuthenticationParameter function doesn't live outside of this and there for the obtained bearer token is never saved to the client object.  I just forced the gettoken function to save to the Token variable that is in AuthenticatorBase.

Please let me know if I am missing something as I would love to learn!  

I do figure that this does not take into account "what if the bearer token expires?"  And to be honest I have no clue how this is handled!  I plan on doing some checks if the request comes back with unauthorized, to get a new token, but if you have ideas or know of better ways to handle bearer tokens expiring please let me know!  I am new to working with APIs.
@dnfadmin
Copy link

dnfadmin commented Nov 1, 2022

CLA assistant check
All CLA requirements met.

@alexeyzimarev
Copy link
Member

Yeah, handling an expired token is not easy, as the authenticator needs to know the response code from the previous call (if it was made) and handle 401. If you have any thought about how to do it, please open an issue.

@alexeyzimarev alexeyzimarev merged commit 95767d4 into restsharp:dev Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants