Add UnsafeAuthenticatedConnectionSharing flag to RestClient #764
Conversation
Add UnsafeAuthenticatedConnectionSharing flag to RestClient so that we can set it to the underlying webrequest.
|
The changes look good. Can you fix the merge conflicts and add some unit tests? |
| /// <summary> | ||
| /// Flag to send authorisation header with the HttpWebRequest | ||
| /// </summary> | ||
| public bool UseUnsafeConnection { get; set; } |
There was a problem hiding this comment.
@KOTRET could you elaborate?
There was a problem hiding this comment.
@alexeyzimarev prop UnsafeAuthenticatedConnectionSharing (Line 203) is definitely in use, but i cannot find usage of the prop UseUnsafeConnection (line 208) , which is also added with this commit.
There was a problem hiding this comment.
This is a public API in a library. "Unused" in this context makes little sense. Most of the public API methods are "unused" inside the library, they are public because people who download the library will use it.
I agree in a sense that if it is "unused" - it means there are no tests for it. This actually is a problem.
There was a problem hiding this comment.
@KOTRET I see what you mean. It is indeed added without any usage.
Add UnsafeAuthenticatedConnectionSharing flag to RestClient so that we
can set it to the underlying webrequest.