New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Mongo id generation regression in a v0.35.1 release #289

Merged
merged 5 commits into from May 4, 2018

Conversation

Projects
None yet
1 participant
@fcamblor
Contributor

fcamblor commented Feb 25, 2018

PR aiming at rolling back jongo / mongo-java-driver / bson4jackson upgrade occured on 0.35 and which implied a critical regression (see #285) with no workaround at that time.

I'd like to make a 0.35.1 release with this rollback.

Upgrade to jongo 1.3.0 (or maybe 1.4.0) will occur someday, but we need to sort out how jongo will handle bson4jackson 2.7 dependency first as currently, jongo 1.3.0 & bson4jackson 2.8.0 are incompatible)

Dependencies rollback compared to 0.35 will be :

  • jongo : 1.3.0 -> 1.1 (I kept 1.0 -> 1.1 upgrade because no regression has been identified on jongo 1.1)
  • mongo-java-driver : 3.4.0 -> 2.11.3 (jongo 1.1 is not compatible with mongo java driver 3.x)
  • bson4jackson : 2.8.0 -> 2.3.1 (bson4jackson 2.8 & 2.7 are not compatible with jongo 1.1)

fcamblor added some commits Feb 7, 2018

Introduced tests on Jongo id generation, spotting regressions in 0.35…
… compared to 0.34 regarding id generation cases
Revert "[breaking] deps - upgraded mongo java driver to 3.4.0 and bso…
…n4jackson to 2.7.0 to follow jongo 1.3.0 upgrade"

This reverts commit 1c07f87.
Revert "Upgraded jongo to 1.3.0"
This reverts commit 9e56b1f.

+ Rolled back jongo new annotations usages in MongoResource

@fcamblor fcamblor self-assigned this Feb 25, 2018

@fcamblor fcamblor requested review from xhanin and a-peyrard Feb 25, 2018

@fcamblor fcamblor changed the title from Fixing Mongo id generation regression to Fixing Mongo id generation regression in a v0.35.1 release Feb 25, 2018

@fcamblor fcamblor changed the base branch from master to 0.35-fixes May 4, 2018

@fcamblor fcamblor merged commit e57019d into restx:0.35-fixes May 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment