Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for jackson version 2 #153

Closed
dya-victor opened this issue Sep 15, 2013 · 10 comments
Closed

Support for jackson version 2 #153

dya-victor opened this issue Sep 15, 2013 · 10 comments

Comments

@dya-victor
Copy link

Support for jackson version 2.x, fasterxml packages for JsonTypeInfo, etc.
Patch can be found there http://yadi.sk/d/EnXhqeYd9HQ2o

@mkristian
Copy link
Member

thanx but I do have problems to appy those patches - maybe not used to it ;)

could you please fork the project and create a topic branch with your changes and send in a pull request.

when I looked through you patch it very much looks like that the this change will break existing projects since they all need to switch to com.fasterxml.jackson.annotation.* . that is more something for restygwt-2.0

@chirino
Copy link
Contributor

chirino commented Sep 16, 2013

Perhaps both versions of the annotations could be supported?

On Mon, Sep 16, 2013 at 5:27 AM, mkristian notifications@github.com wrote:

thanx but I do have problems to appy those patches - maybe not used to it
;)

could you please fork the project and create a topic branch with your
changes and send in a pull request.

when I looked through you patch it very much looks like that the this
change will break existing projects since they all need to switch to
com.fasterxml.jackson.annotation.* . that is more something for restygwt-2.0


Reply to this email directly or view it on GitHubhttps://github.com//issues/153#issuecomment-24498056
.

**

Hiram Chirino

Engineering | Red Hat, Inc.

hchirino@redhat.com hchirino@redhat.com | fusesource.com | redhat.com

*skype: hiramchirino | twitter: @hiramchirinohttp://twitter.com/hiramchirino
*

blog: Hiram Chirino's Bit Mojo http://hiramchirino.com/blog/

@dya-victor
Copy link
Author

Hello! Interesting thought! I will try to figure out, how it can be done without duplication 16.09.2013, 17:31, "Hiram Chirino" notifications@github.com:Perhaps both versions of the annotations could be supported? On Mon, Sep 16, 2013 at 5:27 AM, mkristian notifications@github.com wrote: > thanx but I do have problems to appy those patches - maybe not used to it > ;) > > could you please fork the project and create a topic branch with your > changes and send in a pull request. > > when I looked through you patch it very much looks like that the this > change will break existing projects since they all need to switch to > com.fasterxml.jackson.annotation.* . that is more something for restygwt-2.0 > > — > Reply to this email directly or view it on GitHubhttps://github.com//issues/153#issuecomment-24498056 > . > -- ** Hiram Chirino Engineering | Red Hat, Inc. hchirino@redhat.com hchirino@redhat.com | fusesource.com | redhat.com _skype: hiramchirino | twitter: @hiramchirinohttp://twitter.com/hiramchirino * *blog: Hiram Chirino's Bit Mojo http://hiramchirino.com/blog/_—Reply to this email directly or view it on GitHub.

@ronanquillevere
Copy link
Contributor

Very interested by this upgrade too.

@nloke
Copy link
Contributor

nloke commented Jan 24, 2014

I am also interested with this, most of the projects have moved on to Jackson 2.x, and without this it is really making RestyGwt unusable in a lot of cases.

@nloke
Copy link
Contributor

nloke commented Jan 27, 2014

I forked the project and applied the patch to see if we can possibly support both the annotation from Jackson 1.7 and Jackson 2.0.

I noticed that in the RestGwt.gwt.xml has the following

<replace-with class="org.fusesource.restygwt.emulated.JsonTypeInfo">
    <when-type-is class="org.codehaus.jackson.annotate.JsonTypeInfo"/>
</replace-with>

However, I do not find org.fusesource.restygwt.emulated.JsonTypeInfo and that seems to have been removed based on the following diff. Could this have been introduced back due to a merge issue?

http://fusesource.com/forge/git/restygwt.git/?p=restygwt.git;a=commitdiff;h=78aa89a2daec8a2962f3f19142591f1376826f44

Can you guys shed some light on that so that I can try to address this issue.

@mkristian
Copy link
Member

I can not find the class

org.fusesource.restygwt.emulated.JsonTypeInfo

anywhere. would say we altogether can remove it, but maybe someone else has
more inside here. I will try it soon myself.

  • christian

@Maia-Everett
Copy link
Contributor

I've forked a branch and updated dependencies to the latest Jackson 2.3.2. It compiles and passes the tests. Unfortunately, this version only supports Jackson 2.x annotations, not 1.x.

@seamusmac
Copy link
Contributor

@mkristian This can be now closed I think. :)

@mkristian
Copy link
Member

:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants