Branches not removed after closing Restyle PRs

[pbrisbin]

Regression from the work to name branches restyled/x, instead of x-restyled.

Need to restore the call to deleteReference near (or as part of) closeRestyledPullRequest.

[pbrisbin]

@iphydf can you let me know if this is fixed for you now?

[iphydf]

https://github.com/TokTok/py-toxcore-c/branches it doesn't seem so. Maybe it will work for new ones, but this one (pull-58) wasn't deleted when the PR was closed.

[iphydf]

TokTok/toxins#20 is another PR that has an associated restyled PR: TokTok/toxins#24. Soon, 20 will be rebased on master, which will resolve the style issues, causing 24 to be closed.

[pbrisbin]

Yeah, you can see the error here: https://restyled.io/gh/TokTok/repos/c-toxcore/jobs/269151

It seems like the API call with the / in the branch-name is not being handled correctly. I'm not actually sure how you're supposed to craft the API call, so I'll have to do some testing.

[pbrisbin]

Oh, maybe it's because I'm not prefixing this with heads/. I'll start with some git-diving to see if the pre-regression code did that.

[pbrisbin]

Yes, that's it:

restyler/src/Restyler/PullRequest/Restyled.hs

Lines 175 to 178 in c265572

	runGitHub_ $ deleteReferenceR
	(pullRequestOwnerName pullRequest)
	(pullRequestRepoName pullRequest)
	(mkName Proxy $ "heads/" <> branch)

OK, should be (really) fixed soon.

[iphydf]

@restyled-io restyled-io bot deleted the restyled/pull-31 branch 24 seconds ago

Looks good now.