Implement new wiz.res() API
#41
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul019
reviewed
Apr 12, 2024
| sigfigs: Union[int, None] = None, | ||
| decimal_places: Union[int, None] = None, | ||
| ) -> PrintableResult: | ||
| return res(name, value, [(sys, "sys"), (stat, "stat")], unit, sigfigs, decimal_places) | ||
| ): |
There was a problem hiding this comment.
Why do you not return PrintableResult anymore?
There was a problem hiding this comment.
I do return it in line 94. Make sure to check out the code locally to see the new contents.
It's just the GitHub diff that shows this in a weird way.
There was a problem hiding this comment.
@paul019 Did you find the statement?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #33 and implements the new proposal for the
wiz.res()API.Even though it's not in the scope of this PR, we fix small errors, see 6ef4c44.
For reviewers
plumwas removed as dependency, you may want to runpipenv installagain to uninstall it on your local machine as well.