Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Cache Memories with Wildcard (*) #184

Merged

Conversation

MatsuoTakuro
Copy link
Collaborator

No description provided.

@MatsuoTakuro MatsuoTakuro marked this pull request as ready for review March 29, 2024 00:28
prefix := strings.TrimSuffix(key, "*")
mem.keys.ForEach(func(k string, _ data) bool {
if strings.HasPrefix(k, prefix) {
mem.keys.Del(k)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's use bulk deletion if possible.

@MatsuoTakuro MatsuoTakuro changed the title Delete Cache Memories with Single Wildcard (*) Delete Cache Memories with Wildcard (*) Mar 29, 2024
Copy link
Collaborator

@zhongdalu-trechina zhongdalu-trechina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tanvir-retailai tanvir-retailai merged commit 20c9e82 into develop Mar 29, 2024
1 check passed
@tanvir-retailai tanvir-retailai deleted the feature/support-cache-memory-deletion-with-wildcard branch March 29, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants