Fix crash

retailcoder · May 29, 2015 · 51441f7 · 51441f7
1 parent ab8a10b
commit 51441f7
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 1 deletion.
diff --git a/RetailCoder.VBE/UI/GridViewSort.cs b/RetailCoder.VBE/UI/GridViewSort.cs
@@ -22,6 +22,7 @@ public IEnumerable<T> Sort(IEnumerable<T> Items, string ColumnName)
             if (ColumnName == _columnName && _sortedAscending)
             {
                 _sortedAscending = false;
+                var test = Items.Select(x => x.GetType().GetProperty(ColumnName).GetValue(x));
                 return Items.OrderByDescending(x => x.GetType().GetProperty(ColumnName).GetValue(x));
             }
             else

diff --git a/RetailCoder.VBE/UI/RubberduckUI.Designer.cs b/RetailCoder.VBE/UI/RubberduckUI.Designer.cs
diff --git a/RetailCoder.VBE/UI/RubberduckUI.resx b/RetailCoder.VBE/UI/RubberduckUI.resx
@@ -655,4 +655,7 @@ Warning: All customized settings will be lost.</value>
   <data name="Result" xml:space="preserve">
     <value>Result</value>
   </data>
+  <data name="Outcome" xml:space="preserve">
+    <value>Outcome</value>
+  </data>
 </root>
diff --git a/RetailCoder.VBE/UI/UnitTesting/TestExplorerDockablePresenter.cs b/RetailCoder.VBE/UI/UnitTesting/TestExplorerDockablePresenter.cs
@@ -36,6 +36,9 @@ public TestExplorerDockablePresenter(VBE vbe, AddIn addin, IDockableUserControl
         private void SortColumn(object sender, DataGridViewCellMouseEventArgs e)
         {
             var columnName = Control.GridView.Columns[e.ColumnIndex].Name;
+
+            // type "Image" doesn't implement "IComparable", so we need to sort by the outcome instead
+            if (columnName == RubberduckUI.Result) { columnName = RubberduckUI.Outcome; }
             Control.AllTests = new BindingList<TestExplorerItem>(_gridViewSort.Sort(Control.AllTests.AsEnumerable(), columnName).ToList());
         }
 

diff --git a/RetailCoder.VBE/UI/UnitTesting/TestExplorerItem.cs b/RetailCoder.VBE/UI/UnitTesting/TestExplorerItem.cs
@@ -26,7 +26,7 @@ public void SetResult(TestResult result)
         }
 
         public Image Result { get { return _result.Icon(); } }
-        public QualifiedMemberName QualifiedMemberName { get { return _test.QualifiedMemberName; } }
+        public string QualifiedMemberName { get { return _test.QualifiedMemberName.ToString(); } }
         public string ProjectName { get { return _test.QualifiedMemberName.QualifiedModuleName.Project.Name; } }
         public string ModuleName { get { return _test.QualifiedMemberName.QualifiedModuleName.Component.Name; } }
         public string MethodName { get { return _test.QualifiedMemberName.MemberName; } }