add test and symptomatic fix for jagged arrray resolution

see rubberduck-vba#3098
retailcoder · Nov 15, 2017 · 649fc72 · 649fc72
1 parent cca487c
commit 649fc72
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 1 deletion.
diff --git a/Rubberduck.Parsing/Binding/IndexDefaultBinding.cs b/Rubberduck.Parsing/Binding/IndexDefaultBinding.cs
@@ -127,7 +127,7 @@ private IBoundExpression ResolveLExpressionIsVariablePropertyFunctionNoParameter
             bool isVariable = lExpression.Classification == ExpressionClassification.Variable;
             bool propertyWithParameters = lExpression.Classification == ExpressionClassification.Property && !((IParameterizedDeclaration)lExpression.ReferencedDeclaration).Parameters.Any();
             bool functionWithParameters = lExpression.Classification == ExpressionClassification.Function && !((IParameterizedDeclaration)lExpression.ReferencedDeclaration).Parameters.Any();
-            if (isVariable || ((propertyWithParameters || functionWithParameters) && _argumentList.HasArguments))
+            if (lExpression.ReferencedDeclaration != null && (isVariable || ((propertyWithParameters || functionWithParameters) && _argumentList.HasArguments)))
             {
                 IBoundExpression boundExpression = null;
                 var asTypeName = lExpression.ReferencedDeclaration.AsTypeName;

diff --git a/RubberduckTests/Grammar/ResolverTests.cs b/RubberduckTests/Grammar/ResolverTests.cs
@@ -112,6 +112,32 @@ End Function
             }
         }
 
+        [TestCategory("Resolver")]
+        [TestMethod]
+        public void JaggedArrayReference_DoesNotBlowUp()
+        {
+            // see https://github.com/rubberduck-vba/Rubberduck/issues/3098
+            var code = @"Option Explicit
+
+Public Sub Test()
+    Dim varTemp() As Variant
+    
+    ReDim varTemp(0)
+    
+    varTemp(0) = Array(0)
+    varTemp(0)(0) = Array(0)
+    
+    Debug.Print varTemp(0)(0)
+End Sub
+";
+
+            using (var state = Resolve(code))
+            {
+                var declaration = state.AllUserDeclarations.Single(item => item.DeclarationType == DeclarationType.Variable && item.IdentifierName == "varTemp");
+                Assert.IsTrue(declaration.IsArray);
+            }
+        }
+
         [TestCategory("Resolver")]
         [TestMethod]
         public void OptionalParameterDefaultConstValue_IsReferenceToDeclaredConst()