bad practice to directly call an event procedure

retailcoder · Feb 27, 2015 · 690196e · 690196e
1 parent 0fdb219
commit 690196e
Showing 1 changed file with 22 additions and 19 deletions.
diff --git a/RetailCoder.VBE/UI/ToDoItems/ToDoExplorerDockablePresenter.cs b/RetailCoder.VBE/UI/ToDoItems/ToDoExplorerDockablePresenter.cs
@@ -30,16 +30,35 @@ public ToDoExplorerDockablePresenter(IRubberduckParser parser, IEnumerable<ToDoM
             Control.NavigateToDoItem += NavigateToDoItem;
             Control.RefreshToDoItems += RefreshToDoList;
             Control.SortColumn += SortColumn;
-
-            //RefreshToDoList(this, EventArgs.Empty);
         }
 
         public override void Show()
         {
-            RefreshToDoList(this, EventArgs.Empty);
+            Refresh();
             base.Show();
         }
 
+        public void Refresh()
+        {
+            try
+            {
+                Cursor.Current = Cursors.WaitCursor;
+                var getItems = new Task<IOrderedEnumerable<ToDoItem>>(() => GetItems());
+                getItems.Start();
+
+                Control.TodoItems = getItems.Result;
+            }
+            finally
+            {
+                Cursor.Current = Cursors.Default;
+            }
+        }
+
+        private void RefreshToDoList(object sender, EventArgs e)
+        {
+            Refresh();
+        }
+
         private void SortColumn(object sender, DataGridViewCellMouseEventArgs e)
         {
             var columnName = Control.GridView.Columns[e.ColumnIndex].Name;
@@ -61,22 +80,6 @@ private void SortColumn(object sender, DataGridViewCellMouseEventArgs e)
             Control.TodoItems = resortedItems;
         }
 
-        private void RefreshToDoList(object sender, EventArgs e)
-        {
-            try
-            {
-                Cursor.Current = Cursors.WaitCursor;
-                var getItems = new Task<IOrderedEnumerable<ToDoItem>>(() => GetItems());
-                getItems.Start();
-
-                Control.TodoItems = getItems.Result;
-            }
-            finally
-            {
-                Cursor.Current = Cursors.Default;
-            }
-        }
-
         private IOrderedEnumerable<ToDoItem> GetItems()
         {
             var items = new ConcurrentBag<ToDoItem>();