Fix async mode for bad acct packets.

The code assumed it was running in non-async mode.

lib/radius.js

@@ -291,10 +291,16 @@ for (var code in code_map)
   reverse_code_map[code_map[code]] = code;
 
 Radius.error = function(error_msg, callback) {
-  if (callback)
-    callback(error_msg, null);
-  else
-    throw new Error(error_msg);
+  var err = error_msg;
+  if (typeof(error_msg) === 'string') {
+    err = new Error(error_msg);
+  }
+
+  if (callback) {
+    callback(err, null);
+  } else {
+    throw err;
+  }
 };
 
 Radius.decode = function(args) {
@@ -339,7 +345,8 @@ Radius._decode = function(args) {
     var hash = new Buffer(hasher.digest("binary"), "binary");
 
     if (hash.toString() != this.authenticator.toString()) {
-      throw new Radius.InvalidSecretError("Shared secret does not match", ret);
+      this.error(new Radius.InvalidSecretError("Shared secret does not match", ret), args.callback);
+      return;
     }
   }
 

test/radius.test.js

@@ -349,6 +349,23 @@ module.exports = testCase({
         test.deepEqual( expected_attrs, err.decoded.attributes );
       }
       test.done();
+    },
+
+    test_invalid_accounting_packet_authenticator_async: function(test) {
+      var raw_acct_request = test_args.raw_acct_request;
+      var expected_attrs = test_args.expected_acct_attrs;
+
+      var decode_callback = function(err, packet) {
+        test.ok( err );
+        test.deepEqual( expected_attrs, err.decoded.attributes );
+        test.done();
+      };
+
+      radius.decode({
+        packet: raw_acct_request,
+        secret: 'not-secret',
+        callback: decode_callback
+      });
     }
   },