Add oaidl::ITypeLib, oleauto::LoadTypeLibEx and related definitions. #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arnavion
commented
Mar 20, 2017
|
|
||
| EXTERN!{stdcall fn SysFreeString( | ||
| bstrString: BSTR | ||
| ) -> ()} |
There was a problem hiding this comment.
Is this correct or should it be c_void or something? The header uses the standard C void, no typedefs.
There was a problem hiding this comment.
void return types correspond to () in Rust.
retep998
reviewed
Mar 20, 2017
src/um/oaidl.rs
Outdated
| @@ -526,7 +526,53 @@ interface IDispatch(IDispatchVtbl): IUnknown(IUnknownVtbl) { | |||
| ); | |||
| pub enum IRecordInfo {} // FIXME | |||
| pub enum ITypeComp {} // FIXME | |||
| pub enum ITypeLib {} // FIXME | |||
|
|
|||
| ENUM! { enum SYSKIND { | |||
retep998
reviewed
Mar 20, 2017
src/um/oleauto.rs
Outdated
| @@ -0,0 +1,34 @@ | |||
| // Copyright © 2016-2017 winapi-rs developers | |||
|
If there is duplication the definitions should be duplicated except for structs and interfaces, where one location should be canonical and then the other headers publicly re-export it. |
Okay, changed it to redeclare |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's more in oleauto.h but I've only added what I need for winapi-tlb-bindgen.
There's some amount of duplication between oaidl.h and oleauto.h (both define
DISPIDandMEMBERID, etc) but I figured it would be better to reuse the definitions from theoaidlmodule.MEMBERID_NIL's type comes from its use as the first parameter ofITypeInfo::GetDocumentation()