Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ktmw32-sys (Kernel Transaction Manager) #92

Merged
merged 4 commits into from
May 22, 2015
Merged

ktmw32-sys (Kernel Transaction Manager) #92

merged 4 commits into from
May 22, 2015

Conversation

gentoo90
Copy link
Contributor

@gentoo90 gentoo90 commented May 9, 2015

  • add (Create|Commit|Rollback)Transaction functions of ktmw32.dll
  • add Reg(Create|Open|Delete)Transacted functions of advapi32.dll
  • fixed type of lpClass in signatures of RegCreateKeyExA and RegCreateKeyExW in accordance with MSDN

@gentoo90
Copy link
Contributor Author

gentoo90 commented May 9, 2015

Rust distribution doesn't include ktmw32.a, so linking to ktmw32.dll requires full mingw toolchain (that's why cargo test on appveyor failed).
Do you have any plans of including *.a files into corresponding *-sys crates?

retep998
retep998 reviewed May 9, 2015
View reviewed changes
Cargo.toml
shell32-sys = { path = "lib/shell32-sys" }
user32-sys = { path = "lib/user32-sys" }
uuid-sys = { path = "lib/uuid-sys" }
winmm-sys = { path = "lib/winmm-sys" }
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need the version = "*" bit so that I can upload it to crates.io.

@retep998
Copy link
Owner

retep998 commented May 9, 2015

Not relying on locally installed libraries is something I am considering.

@gentoo90
Copy link
Contributor Author

version = "*" added

@gentoo90
Copy link
Contributor Author

Rebased on the latest master and added libktmw32.a files (in the same way as for dwmapi in 019eb25)

gentoo90
gentoo90 reviewed May 17, 2015
View reviewed changes
lib/ktmw32-sys/build.rs
@@ -1,5 +1,19 @@
// Copyright © 2015, Peter Atashian
// Licensed under the MIT License <LICENSE.md>
use std::env::var;

fn link_win32_lib(libname: &str) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be common for all *-sys crates, but that would require another build dependency.

@gentoo90 gentoo90 mentioned this pull request May 21, 2015
Closed
4 tasks
@gentoo90
Copy link
Contributor Author

Rebased again, and used winapi-build crate

@retep998 retep998 merged commit cbd74b1 into retep998:master May 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gentoo90 @retep998