Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing struct in winsvc.h #956

Merged
merged 1 commit into from Nov 27, 2020
Merged

Add missing struct in winsvc.h #956

merged 1 commit into from Nov 27, 2020

Conversation

nxtn
Copy link
Contributor

@nxtn nxtn commented Nov 12, 2020

No description provided.

@nico-abram
Copy link

Relevant header code:

//
// Service delayed autostart info setting
//
typedef struct _SERVICE_DELAYED_AUTO_START_INFO {
    BOOL       fDelayedAutostart;      // Delayed autostart flag
} SERVICE_DELAYED_AUTO_START_INFO, *LPSERVICE_DELAYED_AUTO_START_INFO;

LGTM, the only thing is maybe we should also add the pointer type below

pub type LPSERVICE_DELAYED_AUTO_START_INFO = *mut SERVICE_DELAYED_AUTO_START_INFO;

I also ran ripgrep in the entire include folder looking for the struct name to check for duplicate definitions just in case, did not find any

Copy link
Contributor

@MaulingMonkey MaulingMonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

  • Organization of code
    • All definitions go into the source file that directly maps to the header the definition is from.
      • C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\um\winsvc.h
    • Definitions are defined in the same order as they are in the original header.
  • Structs
    • Each field must be on its own line.
    • Struct and field names match header.
    • Field types match header.

@retep998 retep998 merged commit 2f76bde into retep998:0.3 Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants