Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retext crashes when synchronised scrolling is enabled #573

Closed
regulartim opened this issue Jan 23, 2022 · 5 comments
Closed

Retext crashes when synchronised scrolling is enabled #573

regulartim opened this issue Jan 23, 2022 · 5 comments

Comments

@regulartim
Copy link

Hi! :)
Whenever I open retext with synchronised scrolling and webkit renderer enabled, it crashes after ~1s with the following message:

Using configuration file: /home/tim/.config/ReText project/ReText.conf
Traceback (most recent call last):
  File "/usr/lib/python3.10/site-packages/ReText/syncscroll.py", line 68, in _handlePreviewResized
    self._updatePreviewScrollPosition()
  File "/usr/lib/python3.10/site-packages/ReText/syncscroll.py", line 137, in _updatePreviewScrollPosition
    pos.setY(preview_scroll_offset)
TypeError: setY(self, int): argument 1 has unexpected type 'float'
Process Process-1:
Traceback (most recent call last):
  File "/usr/lib/python3.10/multiprocessing/process.py", line 315, in _bootstrap
    self.run()
  File "/usr/lib/python3.10/multiprocessing/process.py", line 108, in run
    self._target(*self._args, **self._kwargs)
  File "/usr/lib/python3.10/site-packages/ReText/converterprocess.py", line 72, in _converter_process_func
    job = receiveObject(conn_child)
  File "/usr/lib/python3.10/site-packages/ReText/converterprocess.py", line 41, in receiveObject
    sizeBuf = recvall(sock, 4)
  File "/usr/lib/python3.10/site-packages/ReText/converterprocess.py", line 34, in recvall
    raise EOFError('Received 0 bytes from socket while more bytes were expected. Did the sender process exit unexpectedly?')
EOFError: Received 0 bytes from socket while more bytes were expected. Did the sender process exit unexpectedly?
fish: Job 1, 'retext' terminated by signal SIGABRT (Abbruch)

This problem occurred for quite some time, but I did not have the time to take care of it. I could resolve it today by changing line 137 in syncscroll.py to pos.setY(int(preview_scroll_offset)).

mitya57 added a commit that referenced this issue Jan 23, 2022
This fix is not needed in master branch because we do not support
Qt WebKit anymore.

Fixes #573.
@mitya57
Copy link
Member

mitya57 commented Jan 23, 2022

Hi and thank you for the report!

This bug went unnoticed because it affects only Qt WebKit (not WebEngine) and only with Python 3.10.

I fixed it in retext-7.2 branch now. And I will probably make a new release (7.2.3) when I have time for it.

@mitya57
Copy link
Member

mitya57 commented Feb 3, 2022

The new release is done now.

@fazlerabbi37
Copy link

It seems the issue is back. On my Ubuntu 20.04 machine, it crashes with the same error. Not sure if #515 is related or not but, trying the fix suggested there did not help as well. I have tested it for both latest 8.0.0 installed via pip, for branch version 7.2.3 (Which uses QT5) and latest commit ecc567a.

cc @mitya57

@mitya57
Copy link
Member

mitya57 commented Dec 10, 2022

@fazlerabbi37 Please provide the full traceback. It cannot be the same as in this issue.

@fazlerabbi37
Copy link

just did a clean install to produce the log with pip3 install -U ReText PyQt6-WebEngine --no-cache-dir and pip3 install -U markups PyQt6 PyQt6-WebEngine --no-cache-dir for master branch. Both seems to work file. Sorry for the noise! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants