Add an option to display relative line numbers #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitya57
requested changes
Mar 11, 2017
ReText/__init__.py
Outdated
| @@ -96,7 +97,6 @@ def getBundledIcon(iconName): | |||
| 'useWebKit': False, | |||
| 'windowGeometry': QByteArray(), | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Please do not remove whitespace here.
mitya57
reviewed
Mar 11, 2017
ReText/editor.py
Outdated
| while not atEnd: | ||
| rect = self.editor.cursorRect(cursor) | ||
| block = cursor.block() | ||
| if block.isVisible(): | ||
| number = str(cursor.blockNumber() + 1) | ||
| number = str(cursor.blockNumber() - relativeTo) |
There was a problem hiding this comment.
Can you maybe use a proper typographic minus (−) here? I.e. add .replace('-', '−') to this string?
With this new option, the line numbers are counted as relative from the current line. Fixes retext-project#265
xgouchet
force-pushed
the
relative_line_number
branch
from
a71e8ed
to
bde17b9
Compare
mitya57
added a commit
that referenced
this pull request
Mar 15, 2017
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this new option, the line numbers are counted as relative from the
current line.
Fixes #265