-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show the config file path in the Preferences dialog #327
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the Preferences dialog would be a better place for such information?
Also in Preferences dialog we can use a proper link which would open that file using QDesktopServices, something that we cannot do in About dialog.
(I know there is not much vertical space left in Preferences dialog, but we can reorganize it using tabs. Maybe I will do that when I have more time.)
ReText/window.py
Outdated
@@ -1166,7 +1166,8 @@ def aboutDialog(self): | |||
+'</a> | <a href="http://daringfireball.net/projects/markdown/syntax">' | |||
+self.tr('Markdown syntax') | |||
+'</a> | <a href="http://docutils.sourceforge.net/docs/user/rst/quickref.html">' | |||
+self.tr('reStructuredText syntax')+'</a></p>') | |||
+self.tr('reStructuredText syntax')+'</a></p><p>' | |||
+self.tr('Using configuration file at :')+'<br/>'+getSettingsFilePath()+'</p>') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No space before :
please, it should be there only in French :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
7e78870
to
00ac77e
Compare
So I moved the information in the Config dialog, with a link to open the file as you suggested |
Thank you! |
I have redesigned the preferences dialog a bit, the link is now on top. Any feedback is welcome :) |
This new tabbed interface looks great ! Good work Dmitry ! 👍 |
Fixes #325