Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the config file path in the Preferences dialog #327

Merged
merged 1 commit into from
Oct 3, 2017

Conversation

xgouchet
Copy link
Contributor

@xgouchet xgouchet commented Oct 1, 2017

Fixes #325

Copy link
Member

@mitya57 mitya57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the Preferences dialog would be a better place for such information?

Also in Preferences dialog we can use a proper link which would open that file using QDesktopServices, something that we cannot do in About dialog.

(I know there is not much vertical space left in Preferences dialog, but we can reorganize it using tabs. Maybe I will do that when I have more time.)

ReText/window.py Outdated
@@ -1166,7 +1166,8 @@ def aboutDialog(self):
+'</a> | <a href="http://daringfireball.net/projects/markdown/syntax">'
+self.tr('Markdown syntax')
+'</a> | <a href="http://docutils.sourceforge.net/docs/user/rst/quickref.html">'
+self.tr('reStructuredText syntax')+'</a></p>')
+self.tr('reStructuredText syntax')+'</a></p><p>'
+self.tr('Using configuration file at :')+'<br/>'+getSettingsFilePath()+'</p>')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No space before : please, it should be there only in French :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@xgouchet
Copy link
Contributor Author

xgouchet commented Oct 2, 2017

So I moved the information in the Config dialog, with a link to open the file as you suggested

@mitya57 mitya57 changed the title Show the config file path in the About dialog Show the config file path in the Preferences dialog Oct 3, 2017
@mitya57 mitya57 merged commit 86d3b4a into retext-project:master Oct 3, 2017
@mitya57
Copy link
Member

mitya57 commented Oct 3, 2017

Thank you!

@xgouchet xgouchet deleted the config_file_path branch October 3, 2017 06:04
@mitya57
Copy link
Member

mitya57 commented Oct 15, 2017

I have redesigned the preferences dialog a bit, the link is now on top. Any feedback is welcome :)

@xgouchet
Copy link
Contributor Author

This new tabbed interface looks great ! Good work Dmitry ! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants