Use Ctrl+Mouse wheel to increase / decrease the editor font size #328
Conversation
ReText/editor.py
Outdated
| @@ -401,6 +401,23 @@ def updateTextStatistics(self): | |||
| wordCount += 1 | |||
| self.statistics = (wordCount, alphaNumCount, characterCount) | |||
|
|
|||
| def wheelEvent(self, e: QWheelEvent): | |||
There was a problem hiding this comment.
This requires Python 3.5, but the README says that ReText works with 3.2 or higher. Please update the README or remove this.
There was a problem hiding this comment.
Sorry bout that, I'm used to typed languages :/
ReText/editor.py
Outdated
| if (scroll > 0): | ||
| size = size+1 | ||
| elif (scroll < 0): | ||
| size = size-1 |
There was a problem hiding this comment.
size += 1 / size -= 1 would be a bit cleaner.
Also no parentheses are needed around scroll > 0 / scroll < 0 in Python (unlike C-like languages).
There was a problem hiding this comment.
Yep, habits from other languages :/
There was a problem hiding this comment.
Pyflakes tells me that wheelEvent for ReTextEdit is already defined on line 146. Please update that method instead of creating new one.
Sorry for not noticing it last time…
Upd: I have added pyflakes to Travis so it will be easier to notice such issues next time.
|
Merci! |
|
Anytime ;) |
Fixes #244