Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicates around \r\n are not detected #10

Closed
4 tasks done
a2937 opened this issue Nov 9, 2022 · 2 comments
Closed
4 tasks done

Duplicates around \r\n are not detected #10

a2937 opened this issue Nov 9, 2022 · 2 comments
Labels
👀 no/external This makes more sense somewhere else 👎 phase/no Post cannot or will not be acted on

Comments

@a2937
Copy link

a2937 commented Nov 9, 2022

Initial checklist

Affected packages and versions

retext-repeated-words@4.2.0

Link to runnable example

No response

Steps to reproduce

Background: I was testing to see how well this plugin worked in the spellchecker-cli package when I ran into an unexpected assertion error. The expression Well, it it doesn’t have to to be. Like a fish in the\r\nthe sea. didn't catch the repeated the. Being highly interested in what was causing it; I eventually traced it back to this package and reproduced my example in the local test folder.

I made my local test.js look like the following: https://pastebin.com/ibNziPtb

It had failed. Here is a screenshot.

Unexpected Problem

It hadn't even been caught as an error. I expect it didn't read the \r\n as a whitespace character and maybe need to be take it up with people behind the nlcst package if my suspicions are correct.

Expected behavior

There should have been three strings in the messages array in the example like there is with the \n example.

Affected runtime and version

node@16.14.0

Affected package manager and version

npm@8.5.0

Affected OS and version

Windows 10

Build and bundle tools

Other (please specify in steps to reproduce)

@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Nov 9, 2022
@github-actions

This comment has been minimized.

@wooorm wooorm changed the title Doesn't recognize \r\n as a new line character? Duplicates around \r\n are not detected Nov 10, 2022
@wooorm wooorm added the 👀 no/external This makes more sense somewhere else label Nov 10, 2022
@wooorm
Copy link
Member

wooorm commented Nov 10, 2022

Thanks, found it!

@github-actions github-actions bot added 👎 phase/no Post cannot or will not be acted on and removed 🤞 phase/open Post is being triaged manually labels Nov 10, 2022
@a2937 a2937 mentioned this issue Feb 20, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👀 no/external This makes more sense somewhere else 👎 phase/no Post cannot or will not be acted on
Development

No branches or pull requests

2 participants