Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token no longer stored in localStorage #568

Closed
hswolff opened this issue Jun 7, 2016 · 4 comments
Closed

Token no longer stored in localStorage #568

hswolff opened this issue Jun 7, 2016 · 4 comments
Assignees
Milestone

Comments

@hswolff
Copy link

hswolff commented Jun 7, 2016

Server version: 2.3.4
Client version: 1.1.1

When I try to instantiate Horizon with Horizon({authType: 'anonymous'}) I don't see any token's stored in localStorage.

I compared this behavior to client version 1.0.2 and I saw the token saved in localStorage.

I believe it was this PR that caused this regression: #556

@deontologician
Copy link
Contributor

See #556 (comment) It looks like I have the logic backwards for this :/

@deontologician deontologician added this to the Release 1.x.x milestone Jun 9, 2016
@deontologician deontologician self-assigned this Jun 9, 2016
@deontologician
Copy link
Contributor

Also reported by @Bekt in #570 (comment)

Screencast: http://recordit.co/wsIahMz2KE

Hey, the docs say the JWT token is stored in localStorage, but that doesn't seem to be the case. Please see the recording above.

Horizon version: 1.1.1
Code: index.html

@mardo
Copy link
Contributor

mardo commented Jun 10, 2016

@deontologician
I think this PR solves the issue. I tested locally and it stores the session :)

#579

@hswolff
Copy link
Author

hswolff commented Jun 10, 2016

Woohoo! Awesome! TY!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants