Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distributed code should not contain webpack specific logic #590

Closed
nphyatt opened this issue Jun 14, 2016 · 4 comments
Closed

Distributed code should not contain webpack specific logic #590

nphyatt opened this issue Jun 14, 2016 · 4 comments

Comments

@nphyatt
Copy link
Contributor

nphyatt commented Jun 14, 2016

There is a require statement in the client https://github.com/rethinkdb/horizon/blob/next/client/src/util/fetch.js#L6 which is webpack specific and therefore when I attempt to build using typescript I come up against the following error:

Error: Cannot find module 'imports?this=>global!exports?global.fetch!isomorphic-fetch' from '/Users/home/demo/node_modules/@horizon/client/lib/util'
@imhoffd
Copy link

imhoffd commented Jun 14, 2016

Anyone using horizon's main entry in package.json (lib/index.js) and building their own bundle is essentially forced to use webpack with this line.

@deontologician
Copy link
Contributor

Hey guys, we're going to fix this as soon as possible. We are a little backed up at the moment, so bear with us.

@flipace
Copy link
Contributor

flipace commented Jun 15, 2016

I'm going to work on this today so it should be fixed with the next release. Sorry for the troubles :(

@flipace
Copy link
Contributor

flipace commented Jun 15, 2016

here's the pr: #593

deontologician pushed a commit that referenced this issue Jun 16, 2016
…#477, #420) (#593)

* remove isomorphic-fetch and imports/exports loaders, use whatwg-fetch, replace webpack specific syntax in fetch.js and move it to webpack config

* remove deprecated loaders

* Revert "remove deprecated loaders"

This reverts commit 90bc2d0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants