Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing import command no primary key issue #173

Merged
merged 1 commit into from
Mar 2, 2020

Conversation

gabor-boros
Copy link
Member

Reason for the change
Restoring doesn't pick up primary_key from info files.

Description
In turned out that the primary key was parsed from the info file, but not used at table creation at all, hence the table was created with the default primary key id. The issue was introduced right after 2.3.0.post6 was released in 2016.

Code examples
N/A

Checklist
The whole command structure must be tested. Issue for the problem: #172
- [ ] Unit tests created/modified
- [ ] Integration tests created/modified

References
fixes #171
fixes #157

@gabor-boros gabor-boros added the bug Something isn't working label Feb 22, 2020
@gabor-boros gabor-boros self-assigned this Feb 22, 2020
@gabor-boros
Copy link
Member Author

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 1
- Added 1
           

See the complete overview on Codacy

@gabor-boros gabor-boros merged commit 1089a24 into master Mar 2, 2020
@gabor-boros gabor-boros deleted the fix-171-restore-primary-key branch March 2, 2020 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restoring doesn't pick up primary_key from info files Error restoring a database
1 participant