Allowing dash in DB and table name when using backup tool. #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues
======
- Added 1
See the complete overview on Codacy |
gabor-boros
approved these changes
Apr 10, 2020
|
@hchac, thank you for opening this PR! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(As requested by @gabor-boros at rethinkdb/rethinkdb#6843 (comment) moving the patch here as well.)
Description
Hello,
it seems from rethinkdb/rethinkdb#5537 that '-' is allowed in DB and table names. However, the -e option when using rethinkdb-dump breaks when specifying a DB or table with '-' in its name due to this regex.
Opening this pull request to hopefully fix that.