Update README asyncio example #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 9015f0b and detected 0 issues on this pull request. View more on Code Climate. |
srh
force-pushed
the
srh/asyncio_readme
branch
from
ce236b6
to
ef08ba2
Compare
1 task
lsabi
previously approved these changes
Oct 10, 2023
lsabi
previously approved these changes
Oct 10, 2023
|
@srh My guess is that PRs crash due to the previous PRs getting merged and changing the code with the changes that are also present in this PR |
srh
force-pushed
the
srh/asyncio_readme
branch
from
ef08ba2
to
9015f0b
Compare
|
Since you approved, I'll merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The asyncio example wasn't closing the connection, which resulted in it getting closed outside the event loop. Also,
get_event_loop()is deprecated, so this updates the invocation to useasyncio.run.This depends on #300 getting merged.