Skip to content

Commit

Permalink
Fix RDBBtree.SindexEraseRange unit test
Browse files Browse the repository at this point in the history
We changed how we represent an empty ungrouped stream. It used to be that an
empty ungrouped stream was represented by a map from the NULL group to an empty
`stream_t`, now it's represented by an empty map. (This is more consistent with
how we represent empty grouped streams.)

Review 1280 by @mlucy
Closes #2042
  • Loading branch information
Etienne Laurin committed Mar 3, 2014
1 parent 31d7896 commit a48c3f0
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions src/unittest/rdb_btree.cc
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ void _check_keys_are_NOT_present(btree_store_t<rdb_protocol_t> *store,
rdb_protocol_t::rget_read_response_t res;
double ii = i * i;
/* The only thing this does is have a NULL scoped_ptr_t<trace_t> in it
* which prevents to profiling code from crashing. */
* which prevents the profiling code from crashing. */
ql::env_t dummy_env(NULL, NULL);
rdb_rget_slice(
store->get_sindex_slice(sindex_id),
Expand All @@ -306,10 +306,7 @@ void _check_keys_are_NOT_present(btree_store_t<rdb_protocol_t> *store,

auto groups = boost::get<ql::grouped_t<ql::stream_t> >(&res.result);
ASSERT_TRUE(groups != NULL);
ASSERT_EQ(1, groups->size());
auto stream = &groups->begin()->second;
ASSERT_TRUE(stream != NULL);
ASSERT_EQ(0ul, stream->size());
ASSERT_EQ(0, groups->size());
}
}

Expand Down

0 comments on commit a48c3f0

Please sign in to comment.