Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data explorer - Improve message when there are more than 40 documents #1307

Closed
neumino opened this issue Aug 16, 2013 · 5 comments
Closed

Data explorer - Improve message when there are more than 40 documents #1307

neumino opened this issue Aug 16, 2013 · 5 comments
Assignees
@neumino
Milestone
1.11

Comments

@neumino
Copy link
Member

neumino commented Aug 16, 2013

tw12lve on IRC thought his query just returned 40 documents because he didn't see the "More data" link at the bottom.

We should add something at the top of the page that says there is more data (a "more data" link, or change the message (40 rows displayed).
@ghost ghost assigned neumino Aug 16, 2013
@coffeemug
Copy link
Contributor

I would change the message to something like "40 rows display, more available", and change the style of the "more data" link (it should be much bigger, IMO).

neumino pushed a commit that referenced this issue Aug 21, 2013
Add a if more than 40 rows are returned. Related to #1307
305f5e6
@neumino
Copy link
Member Author

neumino commented Aug 21, 2013

Fixed in michel_1307_more_data
Review 866 assigned to @mglukhovsky

neumino pushed a commit that referenced this issue Sep 3, 2013
Replace >> with an arrow -- Related to #1307
053895a
neumino pushed a commit that referenced this issue Sep 6, 2013
Trying a infobox instead of just a link for -- Related to #1307
c1f8d51
@neumino
Copy link
Member Author

neumino commented Oct 31, 2013

ping @mglukhovsky
Please complete this review. I don't want to have merge conflicts with the data browser.

@mglukhovsky
Copy link
Member

@neumino passing the ball back to you.

neumino pushed a commit that referenced this issue Oct 31, 2013
Fix style according to @mglukhovsky comments. Related to #1307
caf7a88
@neumino
Copy link
Member Author

neumino commented Nov 8, 2013

Review 866 complete
Merged in next as 6dc1395
Ship 1.11

@neumino neumino closed this as completed Nov 8, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neumino neumino

Labels
None yet
Projects
None yet
Milestone
1.11
Development

No branches or pull requests
3 participants
@coffeemug @mglukhovsky @neumino