Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The bubble when hovering over the Shards graph is not positioned correctly #1314

Closed
AtnNn opened this issue Aug 17, 2013 · 4 comments
Closed

The bubble when hovering over the Shards graph is not positioned correctly #1314

AtnNn opened this issue Aug 17, 2013 · 4 comments
Assignees
@neumino
Milestone
1.8.1

Comments

@AtnNn
Copy link
Member

AtnNn commented Aug 17, 2013

In Firefox 23 on OS X:

untitled

It seems to be positioned correctly in Chrome.
@ghost ghost assigned neumino Aug 19, 2013
@neumino
Copy link
Member

neumino commented Aug 20, 2013

Hum, so for Firefox a SVGRectElement doesn't have the property offsetWidth so we get a NaN somewhere in bootstrap-tooltip.js which end up puting the tooltip on the left (left: 0px).

neumino pushed a commit that referenced this issue Aug 20, 2013
Fix bootstrap -- In Firefox, SVGRectElements don't have a offsetWidth…
a5cb1e0 
…/offsetHeight property -- Related to #1314
@neumino
Copy link
Member

neumino commented Aug 20, 2013

Done in branch michel_1314_tooltip_firefox
Review 863 assigned to @mglukhovsky

@neumino
Copy link
Member

neumino commented Aug 21, 2013

Review done, merged in next as 68ee24d

@neumino neumino closed this as completed Aug 21, 2013
neumino pushed a commit that referenced this issue Aug 22, 2013
@neumino
Fix bootstrap -- In Firefox, SVGRectElements don't have a offsetWidth…
9821961 
…/offsetHeight property -- Related to #1314
@neumino
Copy link
Member

neumino commented Aug 22, 2013

Cherry picked in v1.8.x
Ship 1.8.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neumino neumino

Labels
None yet
Projects
None yet
Milestone
1.8.1
Development

No branches or pull requests
2 participants
@AtnNn @neumino