New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The ruby driver silently ignores unknown optional arguments #2052
Comments
I think this check should be done on the server rather than in the clients. That way third-party drivers get it for free. |
Assigning to @gchpaco |
Note that optargs passed to |
Fix for the global optargs thing in CR 2436. |
Should be solved now. |
Sorry to resurrect a dead horse, but re-opening briefly to talk about the set of accepted global optargs. The linked patch makes some global optargs which are currently accepted illegal. I'm not necessarily opposed to doing this, but it seems like a bad idea on the surface: it might break somebody's app and there's no real cost to accepting them. I could very easily see someone wanting to specify e.g. |
The current list is based on what the JavaScript driver used to allow as global opt args. I personally am neutral on the question of whether to allow all opt args globally or only the selected ones. |
The JS driver actually used to reject some legal global optargs, because I forgot to update it for the batch changes. But that's where the list came from. |
Pro accepting all opt args:
Contra accepting all opt args:
|
Further contra: no anti-typo protection. |
@gchpaco By "accepting all opt args" I meant accepting all opt args that are accepted by at least one of the terms. So we would just extend the list, definitely not revert your change. |
OK. |
If we do this, we should make the
Yeah. There are also some optargs which are just outright confusing at the toplevel ( |
Ah that's a good idea. |
Okay. |
That sounds slightly better to me too. All hail backwards compatibility! |
CR 2456. |
This confused a user that was using camel case.
@mlucy pointed out that it would be best to fix this on server, which also silently ignores unknown optional arguments.
The text was updated successfully, but these errors were encountered: