Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python driver - Remove pbcpp.py #2610

Closed
neumino opened this issue Jun 26, 2014 · 7 comments
Closed

Python driver - Remove pbcpp.py #2610

neumino opened this issue Jun 26, 2014 · 7 comments
Assignees
@larkost
Labels
tp:hygiene
Milestone
1.14

Comments

@neumino
Copy link
Member

neumino commented Jun 26, 2014

And the old files that are not used anymore.
It's just about cleaning code, nothing is broken as far as I can tell.

Putting in subsequent.
@neumino neumino added this to the subsequent milestone Jun 26, 2014
@coffeemug coffeemug modified the milestones: 1.14-polish, subsequent Jul 2, 2014
@coffeemug
Copy link
Contributor

Moving to polish. @larkost -- could you take this?

@larkost larkost self-assigned this Jul 2, 2014
@larkost
Copy link
Collaborator

larkost commented Jul 2, 2014

Sure.

larkost added a commit that referenced this issue Jul 9, 2014
@larkost
initial checkin for #2610-remove-pbcpp.py
4b58191
@larkost
Copy link
Collaborator

larkost commented Jul 9, 2014

@neumino Besides the pbcpp.py and _pbcpp.cpp files, and the matching entries in the .gitignore file, do you know of anything else that should be cleaned in this bug?

@neumino
Copy link
Member Author

neumino commented Jul 9, 2014

@larkost, these two files were the one I had in mind when I opened the bug. I'm not aware of any other files we should be removed.

Ping @Tryneus -- anything else we should clean?

@Tryneus
Copy link
Member

Tryneus commented Jul 9, 2014

I don't know of anything, these were just things I missed when doing the initial port to the JSON protocol.

@larkost
Copy link
Collaborator

larkost commented Jul 9, 2014

Since there seem to be no more files, this is up for review 1767, and is on branch larkost/2610-remove-pbcpp.py.

larkost pushed a commit that referenced this issue Jul 10, 2014
merging in #2610 remove pbcpp.py
dd00cb2
@larkost
Copy link
Collaborator

larkost commented Jul 10, 2014

Review is done, and this is merged into next with commit dd00cb2

@larkost larkost closed this as completed Jul 10, 2014
@AtnNn AtnNn modified the milestones: 1.14-polish, 1.14 Aug 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@larkost larkost

Labels
tp:hygiene
Projects
None yet
Milestone
1.14
Development

No branches or pull requests
5 participants
@coffeemug @Tryneus @AtnNn @neumino @larkost