Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r.http uses malformed Accept-Encoding header by default #2695

Closed
marshall007 opened this issue Jul 12, 2014 · 4 comments
Closed

r.http uses malformed Accept-Encoding header by default #2695

marshall007 opened this issue Jul 12, 2014 · 4 comments
Assignees
@Tryneus
Labels
pr:high tp:bug
Milestone
1.13.4

Comments

@marshall007
Copy link
Contributor 

Accept-Encoding: deflate=1;gzip=0.5

Should be (see specification):

Accept-Encoding: deflate;q=1, gzip;q=0.5

I came across this because IIS is apparently pretty picky and was returning 400: Request is badly formed. until I specified correct headers.
@Tryneus
Copy link
Member

Tryneus commented Jul 12, 2014

Dammit, my fault, I'll get this fixed ASAP.

@Tryneus Tryneus added this to the 1.13.x milestone Jul 12, 2014
@Tryneus Tryneus self-assigned this Jul 12, 2014
@Tryneus
Copy link
Member

Tryneus commented Jul 12, 2014

Fixed and merged into next in commit 22a9dff, and cherry-picked into v1.13.x in 66e4366. Review was 1774. Will be in release 1.13.4.

Sorry you ran into this, @marshall007, but thanks for reporting it!

@Tryneus Tryneus closed this as completed Jul 12, 2014
@marshall007
Copy link
Contributor Author

No problem, thanks for the quick fix!

deontologician added a commit to rethinkdb/docs that referenced this issue Jul 23, 2014
@deontologician
Corrected Accept header documentation
0cc30e8 
Fixed docs based on rethinkdb/rethinkdb#2695
deontologician pushed a commit to rethinkdb/docs that referenced this issue Jul 23, 2014
http command header fix
b4599ea 
per rethinkdb/rethinkdb#2695
@deontologician deontologician mentioned this issue Jul 23, 2014
Closed
@larkost
Copy link
Collaborator

larkost commented Aug 18, 2014

@marshall007: This fix is in 1.13.4, which we released today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tryneus Tryneus

Labels
pr:high tp:bug
Projects
None yet
Milestone
1.13.4
Development

No branches or pull requests
3 participants
@Tryneus @marshall007 @larkost